Re: [PATCH v3 3/3] regulator: qcom-refgen: add support for the IPQ9650 SoC
From: Mark Brown
Date: Mon Jun 15 2026 - 13:31:47 EST
On Mon, Jun 15, 2026 at 10:54:26PM +0530, Kathiravan Thirumoorthy wrote:
> On 6/15/2026 9:28 PM, Mark Brown wrote:
> > This looks like a get_status() operation, not an enable operation? The
> > enables and disables are pure clock operations.
> Thanks, Mark for the review. If I understand correctly, I should track the
> clock enable/disable operations and return that state in the is_enabled()
> callback (as I did in v1). Please let me know if my understanding does not
> align with your expectations.
Yes. If as it seems the device can actually implement a get_status()
operation the driver should do that as well.
Attachment:
signature.asc
Description: PGP signature