Re: [PATCH v5 2/3] pwm: rp1: Add RP1 PWM controller driver

[Uwe Kleine-König]

On Sat, Jun 13, 2026 at 01:27:49PM +0100, Julian Braha wrote:
> On 6/12/26 15:01, Andrea della Porta wrote:
> 
> > +config PWM_RASPBERRYPI_RP1
> > +	tristate "RP1 PWM support"
> > +	depends on MISC_RP1 || COMPILE_TEST
> > +	depends on HAS_IOMEM
> > +	select REGMAP_MMIO
> > +	select MFD_SYSCON
> > +	help
> > +	  PWM framework driver for Raspberry Pi RP1 controller.
> > +
> 
> Hi Andrea,
> 
> Selecting REGMAP_MMIO is unnecessary here since you're already selecting
> MFD_SYSCON.

IMHO selecting REGMAP_MMIO explicitly here is fine because at least to
me it's not obvious that MFD_SYSCON enforces REGMAP_MMIO.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature