Re: [PATCH] staging: media: atomisp: fix variable shadowing warnings

[Andy Shevchenko]

On Mon, Jun 8, 2026 at 6:16 PM Rhys Tumelty <rhys@xxxxxxxxxxxxx> wrote:
>
> Fix local variable shadowing warnings, flagged by a W=2
> kernel build, due to -Werror=shadow.
>
> In atomisp_css_stop(), an inner loop 'i' index shadows
> an outer unsigned int i. Rename the inner loop index to 'k'
>
> In ia_css_stream_create(), the block-local 'effective_res'
> struct shadows an outer local declaration. Rename the
> block scoped instance in the loop over pipes to
> 'pipe_effective_res' to clearly show context.

Before even looking towards (some of) the W=2 warnings, please pay
attention to the real issues the driver has.

-- 
With Best Regards,
Andy Shevchenko