Re: [PATCH 2/3] pinctrl: qcom: Fix resolving register base address from device node

[Dmitry Baryshkov]

On Fri, May 29, 2026 at 06:25:45PM +0530, Sneh Mankad wrote:
> Commit 56ffb63749f4 ("pinctrl: qcom: add multi TLMM region option parameter")
> added reg-names property based register reading. However multiple platforms
> are not using the reg-names as they have only single TLMM register region.
> 
> Commit tried to handle this using the default_region module parameter,
> however this condition is unreachable as the error return precedes it by
> just checking if reg-names property exists or not, making it impossible
> to use tlmm-test for the SoCs (x1e80100) which don't have reg-names
> property in TLMM device.
> 
> Fix this by moving the default_region check at the start of the
> tlmm_reg_base().
> 
> Fixes: 56ffb63749f4 ("pinctrl: qcom: add multi TLMM region option parameter")
> Signed-off-by: Sneh Mankad <sneh.mankad@xxxxxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/qcom/tlmm-test.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


-- 
With best wishes
Dmitry