Re: [PATCH 4/5] ASoC: qcom: sc8280xp: Add per-card data

[Hongyang Zhao]

> On Sun, Jun 07, 2026 at 02:58:20AM +0800, Hongyang Zhao wrote:
> > The sc8280xp machine driver currently uses the OF match data only as a
> > driver name, which makes it difficult to describe board-specific MI2S
> > codec requirements.
> > 
> > Convert the match data to a per-card data structure and add data for
> > the QCS6490 RubikPi3. The RubikPi3 data configures the ES8316 MI2S DAI
> > format, MCLK rate, BE hardware parameters and headset jack pins.
> 
> Please don't mix refactoring and actual changes in a single patch. Split
> this commit, performing one logical change per commit.
> 

Thanks for your review.

I will split it in v2. The intended split is:
- convert the sc8280xp OF match data to a per-card data structure;
- add the generic/common helper changes needed for headset jack setup;
- add the RubikPi3-specific machine data, including MI2S codec clocking
  and headset jack configuration.

> > 
> > Add a common headset jack helper which accepts board-specific DAPM pins
> > for codecs that are not connected through the WCD TX codec DMA path.
> > 
> > Signed-off-by: Hongyang Zhao <hongyang.zhao@xxxxxxxxxxxxxxx>
> > ---
> >  sound/soc/qcom/common.c   |  75 ++++++++---
> >  sound/soc/qcom/common.h   |   6 +-
> >  sound/soc/qcom/sc8280xp.c | 319 ++++++++++++++++++++++++++++++++++++++++++----
> >  3 files changed, 357 insertions(+), 43 deletions(-)
> >

--
Thanks,
Hongyang