Re: [PATCH v4 2/5] iio: adc: add Versal SysMon driver

[Erim, Salih]

Hi Andy,

On 07/06/2026 09:08, Andy Shevchenko wrote:
> On Sun, Jun 07, 2026 at 11:06:13AM +0300, Andy Shevchenko wrote:
> > On Sat, Jun 06, 2026 at 06:17:04AM +0100, Salih Erim wrote:
>
> Ah, and missed part below.
>
> ...
>
> > > +#ifndef _VERSAL_SYSMON_H_
> > > +#define _VERSAL_SYSMON_H_
> > > +
> > > +#include <linux/bits.h>
> > > +#include <linux/mutex.h>
>
> > > +#include <linux/types.h>
>
> types.h is not used here.

Accepted. Will remove from P2 and add in P4 where struct
members first need it.

> > > +struct device;
>
> > > +struct iio_dev;
>
> Neither this forward declaration.

Accepted. struct iio_dev is never referenced in the header.
Will remove.

Thanks,
Salih
> > > +struct regmap;
>
> --
> With Best Regards,
> Andy Shevchenko