Re: [PATCH 1/2] xtensa/simdisk: Avoid referring to module::args

[Max Filippov]

On Thu, Jun 4, 2026 at 4:05 AM Petr Pavlu <petr.pavlu@xxxxxxxx> wrote:
>
> When simdisk support is built as a loadable module,
> simdisk_param_set_filename() receives a pointer into module::args and
> stores each filename pointer as is.
>
> In preparation for removing module::args, update the simdisk.filename
> parameter code to copy the provided string. This is somewhat complicated by
> the fact that simdisk support can also be built-in, in which case the
> parameters are parsed during early boot before slab is available. In that
> case, the command line itself is preserved for the lifetime of the kernel,
> so continue storing the incoming pointer directly.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> ---
>  arch/xtensa/platforms/iss/simdisk.c | 38 +++++++++++++++++++++++++----
>  1 file changed, 33 insertions(+), 5 deletions(-)

Reviewed-by: Max Filippov <jcmvbkbc@xxxxxxxxx>

-- 
Thanks.
-- Max