Re: [PATCH v3] media: qcom: iris: guard IRQ handler with runtime PM check
From: Dmitry Baryshkov
Date: Sun Jun 07 2026 - 16:42:47 EST
On Thu, Jun 04, 2026 at 07:55:21AM -0700, Denny Lin wrote:
> > Please clarfiy why you are performing the changes instead of describing
> > the changes on their own. There should be no IRQs coming from the device
> > if it is not active.
>
> My concern was a possible ordering where:
>
> T1:
> iris_hfi_isr()
> -> return IRQ_WAKE_THREAD
>
> T2:
> iris_pm_suspend()
> -> iris_hfi_pm_suspend()
> -> iris_vpu_power_off()
> -> power down the VPU
>
> T3:
> iris_hfi_isr_handler()
> -> iris_vpu_clear_interrupt(core)
>
> Am I missing something that prevents this ordering from occurring?
THis needs to be a part of the commit message.
>
> Thanks,
> Hungyu
--
With best wishes
Dmitry