Re: [PATCH v3 3/3] arm64: dts: qcom: Add Vicharak Axon Mini

[Dmitry Baryshkov]

On Sun, Jun 07, 2026 at 04:30:10PM +0530, Ajit Singh wrote:
> On Sun, Jun 07, 2026 at 01:17:43PM +0530, Dmitry Baryshkov wrote:
> > On Tue, May 19, 2026 at 06:26:55PM +0530, Ajit Singh wrote:
> Thanks for the review.
> > > Add DTS for the Vicharak Axon Mini board based on the Qualcomm
> > > QCS6490 SoC.
> > > 
> > > This adds debug UART, eMMC, UFS, SDIO WLAN, USB 2.0 host, PCIe
> > > support along with regulators.
> > > 
> > > Signed-off-by: Ajit Singh <blfizzyy@xxxxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/qcom/Makefile             |    1 +
> > >  .../dts/qcom/qcs6490-vicharak-axon-mini.dts   | 1025 +++++++++++++++++
> > >  2 files changed, 1026 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-vicharak-axon-mini.dts
> > > 
> > > +
> > > +&pcie0_clkreq_n {
> > > +	bias-pull-up;
> > > +	drive-strength = <2>;
> > > +};
> > 
> > Could you please add a /* pinctrl */ comment at the end of the file and
> > group all pinctrl-related changes after it?
> > 
> Ack
> > > +
> > > +
> > > +&uart5 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&ufs_mem_hc {
> > > +	/delete-property/ qcom,ice;
> > 
> > This should be explained in the commit message.
> > 
> Ack, I will explain this in the commit message.
> 
> ICE is kept disabled because enabling it currently triggers an SError
> during qcom_ice_create() on this board. I am keeping ICE disabled for the
> initial board support.
> > > +
> > > +	reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> > > +	vcc-supply = <&vreg_l7b_2p96>;
> > > +	vcc-max-microamp = <800000>;
> > > +	vccq-supply = <&vreg_l9b_1p2>;
> > > +	vccq-max-microamp = <900000>;
> > > +	vccq2-supply = <&vreg_l9b_1p2>;
> > > +	vccq2-max-microamp = <900000>;
> > > +
> > > +	status = "okay";
> > > +};
> > > +
> > > +&usb_2 {
> > > +	dr_mode = "host";
> > 
> > Is it actually host-only?
> > 
> Yes, this is routed to a USB hub which exposes two USB-A host ports. The board
> does not use this port for OTG or device mode.

Comment it, please.

> > > +
> > > +	status = "okay";
> > > +};
> > > +
> > 
> > -- 
> > With best wishes
> > Dmitry

-- 
With best wishes
Dmitry