Re: [PATCH v3 3/3] arm64: dts: qcom: Add Vicharak Axon Mini

[Dmitry Baryshkov]

On Tue, May 19, 2026 at 06:26:55PM +0530, Ajit Singh wrote:
> Add DTS for the Vicharak Axon Mini board based on the Qualcomm
> QCS6490 SoC.
> 
> This adds debug UART, eMMC, UFS, SDIO WLAN, USB 2.0 host, PCIe
> support along with regulators.
> 
> Signed-off-by: Ajit Singh <blfizzyy@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |    1 +
>  .../dts/qcom/qcs6490-vicharak-axon-mini.dts   | 1025 +++++++++++++++++
>  2 files changed, 1026 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-vicharak-axon-mini.dts
> 
> +
> +&pcie0_clkreq_n {
> +	bias-pull-up;
> +	drive-strength = <2>;
> +};

Could you please add a /* pinctrl */ comment at the end of the file and
group all pinctrl-related changes after it?

> +
> +
> +&uart5 {
> +	status = "okay";
> +};
> +
> +&ufs_mem_hc {
> +	/delete-property/ qcom,ice;

This should be explained in the commit message.

> +
> +	reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> +	vcc-supply = <&vreg_l7b_2p96>;
> +	vcc-max-microamp = <800000>;
> +	vccq-supply = <&vreg_l9b_1p2>;
> +	vccq-max-microamp = <900000>;
> +	vccq2-supply = <&vreg_l9b_1p2>;
> +	vccq2-max-microamp = <900000>;
> +
> +	status = "okay";
> +};
> +
> +&usb_2 {
> +	dr_mode = "host";

Is it actually host-only?

> +
> +	status = "okay";
> +};
> +

-- 
With best wishes
Dmitry