Re: [PATCH] kconfig: warn on dead default
From: Sam Ravnborg
Date: Sat Jun 06 2026 - 13:37:58 EST
Hi Julian.
On Sat, Jun 06, 2026 at 04:01:34PM +0100, Julian Braha wrote:
> On 6/6/26 15:23, Sam Ravnborg wrote:
> > I looks redundant with the two loops were we for the latter knows it is
> > a P_DEFAULT.
>
> Hi Sam,
>
> It may look redundant, but we do need to check each default we encounter
> in the
> ```
> for (prop = sym->prop; prop; prop = prop->next) {
> ```
> loop against the previous defaults to know if we've encountered a
> duplicate default condition.
>
> I guess the other approach would be to copy each default as we encounter
> them into a hashtable and check against that, instead? Let me know if
> you have another, preferred approach.
It was just a drive-by comment, keep it as simple as possible.
Sam