Re: [PATCH v6 0/2] media: qcom: iris: Add generic Gen2 firmware detection and loading

[Dmitry Baryshkov]

On Thu, Jun 04, 2026 at 05:45:35PM +0800, Xilin Wu wrote:
> On 5/29/2026 10:36 PM, Dmitry Baryshkov wrote:
> > This series enhances the Iris driver to support platforms that provide both
> > Gen1 and Gen2 HFI firmware by adding generic runtime firmware generation
> > detection and selection logic.
> > 
> > Some Iris platforms are capable of running either Gen1 or Gen2 HFI‑based
> > firmware, but the driver has historically assumed a single firmware
> > generation selected at build or platform‑definition time. This series
> > updates the firmware loading mechanism to dynamically determine the
> > firmware generation at runtime and select the appropriate HFI
> > implementation accordingly.
> > 
> > When no Device Tree firmware override is present, the driver now prefers
> > Gen2 firmware when available and falls back to Gen1 if loading Gen2
> > fails. When a firmware name is explicitly provided via Device Tree and
> > both Gen1 and Gen2 descriptors are available, the loaded firmware image
> > is inspected prior to authentication to determine its generation. Based
> > on this detection, the driver updates its firmware descriptor and
> > platform data so that the correct HFI implementation is used.
> > 
> 
> [...]
> 
> FWIW, I am testing the Gen2 firmware on sc8280xp, although it is supposed to
> be used on sm8350 (lahaina). The original filename is vpu20_4v.mbn.

I think SM8350 was shipped with Gen1 firmware. Most likely you are
looking at the firmware file for SM8450?

> 
> It actually works quite well on sc8280xp with some Device Tree changes [1].
> So far, I have not observed any crashes or reboots. Could someone from
> Qualcomm clarify whether the Gen2 firmware is expected to work on targets
> such as sm8250, sm8350, and sc8280xp?

The changes look reasonable. Please submit them upstream. Consider
expanding them to SM8250 and SM8350, I will be able to verify those
platforms.

> 
> [1] https://github.com/strongtz/linux-radxa-qcom/commits/v7.0.11-qcom/arch/arm64/boot/dts/qcom

-- 
With best wishes
Dmitry