Re: [PATCH 3/4] clk: qcom: convert from icc_sync_state() to qcom_cc_sync_state()

[Jens Glathe]

On 03.06.26 16:21, Brian Masney wrote:
> Convert all of the qcom clk drivers from icc_sync_state() to
> qcom_cc_sync_state().
>
> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
> ---
[...]
>   
> diff --git a/drivers/clk/qcom/clk-cbf-8996.c b/drivers/clk/qcom/clk-cbf-8996.c
> index 0b40ed601f9a..0d920bd5a992 100644
> --- a/drivers/clk/qcom/clk-cbf-8996.c
> +++ b/drivers/clk/qcom/clk-cbf-8996.c
> @@ -6,7 +6,6 @@
>   #include <linux/clk.h>
>   #include <linux/clk-provider.h>
>   #include <linux/interconnect-clk.h>
> -#include <linux/interconnect-provider.h>
>   #include <linux/of.h>
>   #include <linux/module.h>
>   #include <linux/platform_device.h>
> @@ -249,7 +248,7 @@ static void qcom_msm8996_cbf_icc_remove(struct platform_device *pdev)
>   
Hi Brian, thank you for the patch set. To successfully build there seems 
to be a header missing. I tested this in my tree on Thinkbook 16 G7 QOY 
and Ideapad Slim3x 15Q8X10 without adverse effects, looking good.

jglathe@tb16-jg:~$ sudo dmesg|grep "unused clocks"
[    0.492547] clk: Disabling unused clocks not associated with a device
[    1.178818] clk-rpmh 17500000.rsc:clock-controller: clk: Disabling 
unused clocks
[    1.314479] qcom-edp-phy aec5a00.phy: clk: Disabling unused clocks
[    1.327608] tcsrcc-x1e80100 1fc0000.clock-controller: clk: Disabling 
unused clocks
[    1.544869] qcom-qmp-combo-phy fdf000.phy: clk: Disabling unused clocks
[    1.614767] qcom-qmp-usb-phy 88e5000.phy: clk: Disabling unused clocks
[    1.616222] qcom-qmp-usb-phy 88e3000.phy: clk: Disabling unused clocks
[    1.690273] qcom-qmp-combo-phy fd5000.phy: clk: Disabling unused clocks
[    1.726354] qcom-qmp-pcie-phy 1bfc000.phy: clk: Disabling unused clocks
[   10.956342] qcom-qmp-pcie-phy 1c0e000.phy: clk: Disabling unused clocks
[   15.858926] q6prm-lpass-clock 
6800000.remoteproc:glink-edge:gpr:service@2:clock-controller: clk: 
Disabling unused clocks
[   15.867120] rx_macro 6ac0000.codec: clk: Disabling unused clocks
[   15.867990] wsa_macro 6aa0000.codec: clk: Disabling unused clocks
[   15.868589] va_macro 6d44000.codec: clk: Disabling unused clocks
[   15.970465] wsa_macro 6b00000.codec: clk: Disabling unused clocks
[   15.973614] tx_macro 6ae0000.codec: clk: Disabling unused clocks

Tested-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>

with best regards,

Jens

---
From ac259285bc626800d5f1216bd5b276ada99295bd Mon Sep 17 00:00:00 2001
From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 4 Jun 2026 22:03:20 +0200
Subject: [PATCH] clk: qcom: clk-cbf-8996: Include common.h for
 qcom_cc_sync_state

After switching to qcom_cc_sync_state in the clk sync_state series,
clk-cbf-8996.c was missing the declaration. Fix build error by
including common.h.

Fixes: 20260603-clk-sync-state series

Signed-off-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
---
 drivers/clk/qcom/clk-cbf-8996.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/clk-cbf-8996.c 
b/drivers/clk/qcom/clk-cbf-8996.c
index 0d920bd5a9929..6abc70ebf6f19 100644
--- a/drivers/clk/qcom/clk-cbf-8996.c
+++ b/drivers/clk/qcom/clk-cbf-8996.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
+#include "common.h"

 #include <dt-bindings/interconnect/qcom,msm8996-cbf.h>

--

2.53.0