Re: [RFC PATCH v3 0/4] mm/damon: Introduce a huge page collapsing mechanism using auto tuning

[SeongJae Park]

On Fri, 5 Jun 2026 13:25:56 +0300 Gutierrez Asier <gutierrez.asier@xxxxxxxxxxxxxxxxxxx> wrote:

> Hi SJ,
> 
> On 6/5/2026 4:34 AM, SeongJae Park wrote:
> > Hello Asier,
> > 
> > 
> > Thank you for revisioning this great patch!
> > 
> > On Thu, 4 Jun 2026 15:03:33 +0000 <gutierrez.asier@xxxxxxxxxxxxxxxxxxx> wrote:
[...]
> >> Benchmarks
> >> ==========
[...]
> > Also, have you tried temporal quota tuner?
> 
> OK, I will give it try.

Sounds good!  These test results are great contributions for DAMON community.
Nonetheless I don't think those are blocker of this series.  You could run more
tests and share results even after this series is merged first if you want to.

[...]
> >> Patches Sequence
> >> ================
> >> Patch 1 -> Introduce DAMOS_QUOTA_HUGEPAGE and autotuning
> >> Patch 2 -> damon_modules_new_vaddr_ctx_target
> >> Patch 3 -> Module that demonstrates how to use DAMOS_QUOTA_HUGEPAGE
> >>            and the new VADDR ctx creation
> >> Patch 4 -> Documentation
> > 
> > As I commented to each patch, patch 1 looks good except a few trivial things.
> > Patch 2 seems unnecessary.  I hope patch 3 to be much simplified and wrote
> > again following the sample modules' pattern.  Patch 4 seems too much for a
> > sample module.
> Thanks for the feedback, I will work out the patches.

I have a trivial comment about the 32-bit overflow issue, but everythinng
except that look good to me.

I feel like we are going on the right direction and this series is getting
closer to land!


Thanks,
SJ

[...]