Re: [PATCH] dt-bindings: media: Add macros for video interface devices

[Laurent Pinchart]

On Sat, Jun 06, 2026 at 12:36:31AM +0300, Sakari Ailus wrote:
> Hi Laurent, Kieran,
> 
> On Fri, Jun 05, 2026 at 06:13:53PM +0300, Laurent Pinchart wrote:
> > CC'ing Sakari.
> 
> Thanks for cc'ing me.
> 
> > On Fri, Jun 05, 2026 at 04:03:08PM +0100, Kieran Bingham wrote:
> > > Add a new dt-bindings/media/video-interface-devices.h header that
> > > defines macros corresponding to the orientation enumeration types from
> > > media/video-interface-devices.yaml.
> > > 
> > > This allows avoiding hardcoded constants in device tree sources.
> > > 
> > > Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> > > ---
> > >  include/dt-bindings/media/video-interface-devices.h | 13 +++++++++++++

A mention of the header in video-interface-devices.yaml would be useful,
the same way we mention video-interfaces.h in video-interfaces.yaml.
Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> > >  1 file changed, 13 insertions(+)
> > >  create mode 100644 include/dt-bindings/media/video-interface-devices.h
> > > 
> > > diff --git a/include/dt-bindings/media/video-interface-devices.h b/include/dt-bindings/media/video-interface-devices.h
> > > new file mode 100644
> > > index 000000000000..d2340b457292
> > > --- /dev/null
> > > +++ b/include/dt-bindings/media/video-interface-devices.h
> > > @@ -0,0 +1,13 @@
> > > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> > > +/*
> > > + * Copyright (C) 2026 Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> > > + */
> > > +
> > > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> > > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> > > +
> > > +#define MEDIA_ORIENTATION_FRONT		0
> > > +#define MEDIA_ORIENTATION_BACK		1
> > > +#define MEDIA_ORIENTATION_EXTERNAL	2
> > > +
> > > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__ */
> 
> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

-- 
Regards,

Laurent Pinchart