Re: kernel NULL pointer dereference in quirk_clear_strap_no_soft_reset_dev2_f0 -> amd_smn_read

[Marek Marczykowski-Górecki]

On Fri, Jun 05, 2026 at 02:15:43PM -0700, Borislav Petkov wrote:
> On Fri, Jun 05, 2026 at 10:23:18PM +0200, Marek Marczykowski-Górecki wrote:
> > Instead of the series? No, that's not enough. amd_smn_read() is called
> > from quirk_clear_strap_no_soft_reset_dev2_f0, so it would still hit NULL
> > at amd_roots in __amd_smn_rw(). But if you mean instead of the first
> > patch (but apply the second as is), it should work. I don't have
> > affected hardware, but I'll ask the affected user to test this version.
> 
> amd_smn_read() should not happen in guests. It is that simple.

Well, it clearly happens, see the call trace in the first message of the
thread...
Do you suggest the fix should change
quirk_clear_strap_no_soft_reset_dev2_f0()?

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature