Re: [PATCH] nouveau/firmware: fix memory leak on BL load failure

From: Timur Tabi

Date: Fri Jun 05 2026 - 14:31:36 EST


On Fri, 2026-06-05 at 10:07 +0800, Dawei Feng wrote:
>   if (bl) {
>   nvkm_firmware_put(blob);
> + blob = NULL;
>  

I think it would be cleaner to instead delete this nvkm_firmware_put(blob) call here, and just rely
on the call to nvkm_firmware_put() at the end of nvkm_falcon_fw_ctor_hs(). Then you won't need
"blob = NULL".