Re: [PATCH v2 01/10] soundwire: Always wait for initialisation of unattached devices

[Charles Keepax]

On Fri, Jun 05, 2026 at 12:43:24PM +0100, Srinivas Kandagatla wrote:
> some minor typos in commit msg.
> 
> On 6/5/26 9:48 AM, Charles Keepax wrote:
> > Currently in sdw_slave_wait_for_init() the waiting can be skipped
> > if unattach_request is not set. Doing so was added in [1] likely
> > because the core used to do a complete() on the completion so
> > waiting in the case an unattach hadn't actually happened would
> > block for the full timeout. However patch [2] updated the core to
> > use complete_all() which means that the wait_for_completion() will
> > now simply return if the device is already attached skipping the
> > completion doesn't add much.
> > 
> > Additionally, unatttach_request is only set if the host initiates
> 
>  s/unatttach/unattach
> 
> > a bus reset. However, the host doing a bus reset is not the only
> > reason a device may be unattached from the bus. Other options
> > could include the driver probing before the device enumerates, a
> > sync-loss, or the device itself powering down.
> > 
> > Removing the skip using unattached_request, doesn't cost much in
> > terms of efficiency and allows the sdw_slave_wiat_for_init() helper
> s/wiat/wait
> 

Thanks I will do a spin early next week for these typos.

Thanks,
Charles