Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add Sony IMX678

[Conor Dooley]

On Fri, Jun 05, 2026 at 08:56:28PM +0530, Jai Luthra wrote:
> Sony IMX678 is an 8.4 Megapixel (3856x2180) CMOS sensor, that can output
> pixels over MIPI CSI-2 bus. Add bindings for it.
> 
> Runtime detection for mono vs color variant of this sensor is feasible
> by reading a register, but it's not always desirable given the sensor
> needs to be powered on for it, potentially flashing a privacy LED or
> wasting precious boot time.
> 
> The manufacturer or vendor knows which sensor variant they are putting
> on their board, so we define the compatible property to expect the
> (color/mono) specific name of the sensor.


> This should still be followed by the generic fallback device name,
> "sony,imx678". If some vendor wants to share firmware (DT blobs) across
> "products" or SKUs that only differ in the mono vs color variant of the
> sensor used, they *can* do it by skipping the specific name at the cost
> of a build-time warning from dtbs_check.
> 
> Drivers are expected to handle all three device names (two specific, and
> the generic fallback) gracefully.

I don't agree with this having this statement in the commit message, but
you're free to do it in the linux driver if the subsystem maintainers
tolerate it. This isn't how the compatible property is expected to be
used, and writing a note in a commit message doesn't define the ABI.
If, in the probably unlikely case, someone in bsd or $other-os wants to
support this device, they're not bound to make the same decision you
have.

With it gone,
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

pw-bot: changes-requested

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature