Re: [PATCH v3] spi: cadence-xspi: Support 32bit and 64bit slave dma interface

From: Mark Brown

Date: Fri Jun 05 2026 - 07:51:44 EST


On Thu, Jun 04, 2026 at 07:06:34PM -0700, Nathan Chancellor wrote:
> On Thu, Jun 04, 2026 at 11:30:27AM +0100, Mark Brown wrote:

> > Ah, the patch is fine then - I must have been looking at a fixes tree
> > without the dependency when I reviewed it, I'd forgotten that Marvell
> > update had gone in.

> Your 7.2 tree has commit 0c5b5c40dc31 ("spi: cadence-xspi: Add
> COMPILE_TEST support") in it, so this driver does build on 32-bit
> platforms now. -next is broken with

...

> which would not happen if the 64BIT dependency was there. If
> 0c5b5c40dc31 is to remain around, it seems like option A upthread is
> needed.

TBH I'm fine with dropping that given that it was purely for coverage
and at this point the overwhelming majority of new development is done
on 64 bit architectures so the coverage benefit is a bit limited. I'm
not aware of there being any 32 bit hardware using the controller, the
commit log doesn't suggest any.

Attachment: signature.asc
Description: PGP signature