Re: [PATCH net-next v1 1/5] net: phy: realtek: add support for dummy phy

[Maxime Chevallier]

Hi,

On 6/5/26 11:43, Javen wrote:
> 
> Hi,
> 
>>> You are exactly right. The PHY doesn't actually exist; what we have is
>>> an internal PCS.
>>
>> ...
>>
>>> I actually tried to migrate it to
>>> phylink before. However, the current driver codebase is deeply coupled
>>> with tp->phydev in many places. Decoupling it may introduce bugs for
>>> numerous existing devices. Therefore, I want to try to expose the
>>> internal PCS as a dummy PHY device.
>>
>> Architecturally, you are going down a dead end. You really should be using
>> phylink.
>>
>> I don't see anything too scary with tp->phydev in the driver. Are there parts
>> you think are going to be a problem with phylink?
>>
>>      Andrew
> 
> Thanks for your suggestion.
> 
>  Since I am not very familiar with phylink,  so I may have been too conservative about the migration. I have prepared a version using phylink and will submit it for review.
> 
> Any comments or suggestions would be very helpful.

We can help reviewing this, indeed :)

You should be able to follow the porting guide here :

https://docs.kernel.org/networking/sfp-phylink.html

It was updated not too long ago :)

Maxime

> 
> Thanks,
> BRs,
> Javen