Re: [PATCH v2 1/5] dt-bindings: soc: cix,sky1-system-control: add audss system control

[Krzysztof Kozlowski]

On 05/06/2026 11:18, Krzysztof Kozlowski wrote:
> On 05/06/2026 05:22, joakim.zhang@xxxxxxxxxxx wrote:
>>    compatible:
>> -    items:
>> -      - enum:
>> -          - cix,sky1-system-control
>> -          - cix,sky1-s5-system-control
>> -      - const: syscon
>> +    oneOf:
>> +      - items:
>> +          - enum:
>> +              - cix,sky1-system-control
>> +              - cix,sky1-s5-system-control
>> +          - const: syscon
>> +      - items:
>> +          - const: cix,sky1-audss-system-control
>> +          - const: simple-mfd
>> +          - const: syscon
>>  
>>    reg:
>>      maxItems: 1
>> @@ -27,6 +32,11 @@ properties:
>>    '#reset-cells':
>>      const: 1
>>  
>> +  clock-controller:
>> +    $ref: /schemas/clock/cix,sky1-audss-clock.yaml#
>> +    description:
>> +      AUDSS internal clock provider (cix,sky1-audss-system-control only).
> 
> Are you sure this patch builds? Your cover letter should explain merging

I am sure it does not...

I recommend switching to compatible-style of defining subnodes in parent
schema which would decouple patches.

example:
https://elixir.bootlin.com/linux/v7.1-rc6/source/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml#L41

> dependencies/strategy/constraints in the first chapter. You start with
> THE MOST important information.
> 
> You need to disallow node for other variants.
> 
>


Best regards,
Krzysztof