Re: [PATCH] mm/memory-failure: trace: change memory_failure_event to ras subsystem

[David Hildenbrand (Arm)]

On 6/5/26 10:12, Xie Yuanbin wrote:
> For historical version, commit 97f0b1345219 ("tracing: add trace event
> for memory-failure") introduced memory_failure_event in ras subsystem.
> commit 31807483d395 ("mm/memory-failure: remove the selection of RAS")
> changed memory_failure_event to memory_failure subsystem. This breaks
> the backward compatibility, some user programs rely on it.
> 
> Change memory_failure_event to ras subsystem to keep backward
> compatibility.
> 
> Fixes: 31807483d395 ("mm/memory-failure: remove the selection of RAS")
> 
> Reported-by: Yi Lai <yi1.lai@xxxxxxxxx>
> Reported-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
> Closes: https://lore.kernel.org/linux-mm/CY8PR11MB7134346A3E4BB28ECA28D6E989132@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: David Hildenbrand <david@xxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> Signed-off-by: Xie Yuanbin <xieyuanbin1@xxxxxxxxxx>
> ---
>  include/trace/events/memory-failure.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/memory-failure.h b/include/trace/events/memory-failure.h
> index aa57cc8f896b..7a8ee5d1a44e 100644
> --- a/include/trace/events/memory-failure.h
> +++ b/include/trace/events/memory-failure.h
> @@ -1,6 +1,10 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  #undef TRACE_SYSTEM
> -#define TRACE_SYSTEM memory_failure
> +/*
> + * For historical versions, memory_failure_event is in ras subsystem,
> + * some user programs depend on it.
> + */
> +#define TRACE_SYSTEM ras
>  #define TRACE_INCLUDE_FILE memory-failure
>  
>  #if !defined(_TRACE_MEMORY_FAILURE_H) || defined(TRACE_HEADER_MULTI_READ)

We should

Cc: <stable@xxxxxxxxxxxxxxx>

given that it's in v6.19 and nobody noticed :(

Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

Thanks, and fortunately now I learned about possible ABI salability of trace events.

-- 
Cheers,

David