Re: [PATCH v2 0/2] net/mlx5: Only consider online CPUs in affinity subset check

[Shay Drori]

On 04/06/2026 15:57, Fushuai Wang wrote:
> External email: Use caution opening links or attachments
>
>
> From: Fushuai Wang <wangfushuai@xxxxxxxxx>
>
> Hi all,
>
> When an SF is created after a CPU has been taken offline, the IRQ affinity
> check fails because existing IRQs in the pool may have affinity masks that
> include the now-offline CPU. This causes SF creation to fail even though
> suitable online CPUs are available.
>
> This series fixes this issue and includes a small cleanup:
>
> Patch 1 folds cpumask_copy() into cpumask_andnot() for better code clarity
> in comp_irq_request_sf().
>
> Patch 2 filters affinity masks to only consider effective CPUs before the
> subset check, ensuring SF creation succeeds when CPUs have been taken offline.

Thanks for the patches.
two points:
1) you need to add branch name to the title (PATCH net ...)
2) you need to keep a change-log.

The first patch is net-next material, and the second patch is net.
I think it would be better to send each one separately to its own branch.
sorry didn't notice on prev review...

> --WANG
>
> Fushuai Wang (2):
>    net/mlx5: Simplify cpumask operations in comp_irq_request_sf()
>    net/mlx5: Use effective affinity mask for IRQ selection
>
>   drivers/net/ethernet/mellanox/mlx5/core/eq.c           | 3 +--
>   drivers/net/ethernet/mellanox/mlx5/core/irq_affinity.c | 5 ++++-
>   2 files changed, 5 insertions(+), 3 deletions(-)
>
> --
> 2.36.1