RE: [PATCH net] r8152: handle the return value of usb_reset_device()
From: Chih Kai Hsu
Date: Thu Jun 04 2026 - 22:46:49 EST
On 04/06/26 8:54 pm, Andrew Lunn wrote:
> On Thu, Jun 04, 2026 at 05:22:47PM +0800, Chih Kai Hsu wrote:
> > If usb_reset_device() returns a negative error code, stop the process
> > of probing.
> >
> > Fixes: 10c3271712f5 ("r8152: disable the ECM mode")
>
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>
> Does this bother people?
Yes, it does.
If the driver does not return early when receiving an error code from usb_reset_device(),
the subsequent execution will trigger a kernel call trace.
>
> Andrew
Best Regards,
Chih Kai