Re: [PATCH v5 12/21] KVM: selftests: Verify interrupts are received after modifying IRQ routes in IRQ test

[Sean Christopherson]

This is _very_ misleading.  The test _already_ verifies routing changes.  This
is specifically setting empty routing, to validate that KVM doesn't barf on a
complete teardown of routing.

On Thu, Jun 04, 2026, Josh Hilke wrote:
> From: David Matlack <dmatlack@xxxxxxxxxx>
> 
> Add the '-c' flag to tools/testing/selftests/kvm/irq_test.c to destroy

I feel quite strong that this need to be -e for "empty", not -c for "clear".
Because there are many different ways the test could "clear" routing, e.g. it
could nullify just the target IRQ's entry, set the entry to a suppress the IRQ,
etc.

> and recreate KVM's GSI routing table between interrupts. This ensures
> that KVM correctly handles dynamic updates to the interrupt routing
> table while interrupts are actively being signaled by assigned devices.
> 
> Co-developed-by: Josh Hilke <jrhilke@xxxxxxxxxx>
> Signed-off-by: Josh Hilke <jrhilke@xxxxxxxxxx>
> Signed-off-by: David Matlack <dmatlack@xxxxxxxxxx>

SoB order is wrong (here and in several other patches).  It needs to be:

    Signed-off-by: David Matlack <dmatlack@xxxxxxxxxx>
    Co-developed-by: Josh Hilke <jrhilke@xxxxxxxxxx>
    Signed-off-by: Josh Hilke <jrhilke@xxxxxxxxxx>

Please read Documentation/process/5.Posting.rst and
Documentation/process/submitting-patches.rst.