Re: [PATCH] checkpatch: Check WQ_PERCPU or WQ_UNBOUND presence in alloc_workqueue() users

[Marco Crivellari]

On Thu, Jun 4, 2026 at 4:09 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Thu, 2026-06-04 at 11:31 +0200, Marco Crivellari wrote:
> > On Thu, Jun 4, 2026 at 7:08 AM Joe Perches <[joe@xxxxxxxxxxx](mailto:joe@xxxxxxxxxxx)> wrote:
> > [...]
> > > OK but a couple comments:
> > >
> > > Add devm_alloc_workqueue as well?
> >
> > No I don't think it would be useful / needed. There is only 1 user of
> > that macro, devm_alloc_ordered_workqueue(), which already specifies
> > the WQ_UNBOUND flag and it is part of the workqueue code.
>
> drivers/power/supply/ipaq_micro_battery.c:      mb->wq = devm_alloc_workqueue(&pdev->dev, "ipaq-battery-wq",
>
> Maybe there will be more.

Yes it is the only one in v7.1-rc6.

BTW, let's keep the new regex for both macros, it's not a problem, so
we can cover both cases.

Thanks!

-- 

Marco Crivellari

SUSE Labs