RE: [PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532

[Paller, Kim Seer]

> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Sent: Thursday, June 4, 2026 5:37 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; David Lechner
> <dlechner@xxxxxxxxxxxx>; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Andy
> Shevchenko <andy@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; linux-
> iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux <linux@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 0/3] iio: dac: ad3530r: Add support for AD3532R/AD3532
> 
> On Thu, Jun 04, 2026 at 03:13:42PM +0800, Kim Seer Paller wrote:
> > This series adds support for the AD3532R/AD3532, a 16-channel, 16-bit
> > voltage output DAC, to the existing ad3530r driver.
> >
> > The AD3532R uses a dual-bank register architecture (bank 0 at 0x1000
> > for channels 0-7, bank 1 at 0x3000 for channels 8-15), which required
> > refactoring the register access paths. A table-driven register bank
> > approach is introduced where per-chip register address arrays in
> > chip_info are iterated by helper functions, replacing the
> > single-register setup calls for existing variants and scaling
> > naturally to the AD3532R's dual-bank layout.
> >
> > The series also adds AD3532R-specific powerdown modes (1kohm_to_gnd,
> > 10kohm_to_gnd, three_state) and a new ABI entry for the 10kohm_to_gnd
> > powerdown mode.
> 
> This cover letter misses two required things:
> - why do we need a brand new driver (provide an explanation)?
> - where to get the datasheet (provide a link)?

Hi,

The AD3532R is part of the AD3530R family and shares similar
functionality (channel configuration, LDAC triggering, powerdown
control). It extends the existing ad3530r driver as the underlying
workflow remains the same. The main difference being the register
address map due to the dual-bank architecture, which is handled
by table-driven helpers introduced in this series.

Here's the datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad3532r.pdf

> 
> Just reply to this email and if new version is required do not forget to add it to
> the cover letter.
> 
> --
> With Best Regards,
> Andy Shevchenko
>