Re: [PATCH 2/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2

From: David Laight

Date: Thu Jun 04 2026 - 05:23:13 EST


On Thu, 4 Jun 2026 00:17:36 +0300
Askar Safin <safinaskar@xxxxxxxxx> wrote:

> Stefan Metzmacher <metze@xxxxxxxxx>:
> > Why is 'int fd' changed to 'unsigned long fd'?
>
> Because preadv2 and pwritev2 take "unsigned long". I want vmsplice
> to be as similar as possible to preadv2 and pwritev2.

Something needs to ensure that the high 32bits of the fd get masked off
on 64bit systems.
They can be non-zero in the register that comes from userspace.

-- David

>
> > Should that be its own commit if the change is desired?
>
> Yes, possibly. But this patchset already got to next.
>