Re: [PATCH v3 03/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl

[Changhuang Liang]

Hi, Conor

Thanks for the review.

> On Tue, Jun 02, 2026 at 10:53:29PM -0700, Changhuang Liang wrote:
> 
> > +          slew-rate:
> > +            enum: [ 0, 1 ]
> > +            default: 0
> > +            description: |
> > +                0: slow (half frequency)
> 
> Half frequency? Slew rates are usually measured in volts per second, not hertz.
> Do you know what the slew rates actually are and could put them in here as
> the real units? Or is it just "slow" and "fast" in your docs with no precise
> numbers?

Yes, there are no precise numbers in our documentation. I will remove "(half frequency)" in the next version.

> I've got no questions other than this, so once this question is sorted, I'll be
> happy to ack all the bindings provided they're effectively the same.
> 
> > +                1: fast

Best Regards,
Changhuang