Re: [PATCH net-next V2 7/7] devlink: Add eswitch mode boot defaults

[Randy Dunlap]

Hi.

On 6/3/26 12:32 PM, Mark Bloch wrote:
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 063c11ca33e5..7af9f2898d92 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1264,6 +1264,31 @@ Kernel parameters
>  	dell_smm_hwmon.fan_max=
>  			[HW] Maximum configurable fan speed.
>  
> +	devlink_eswitch_mode=
> +			[NET]
> +			Format:
> +			[<selector>]:<mode>

It appears (please correct me if I am mistaken) that the '[' and ']'
above don't mean "optional" but instead they are required characters...

> +
> +			<selector>:
> +			* | <handle>[,<handle>...]

while here they mean "optional".

That is confusing (inconsistent). Also, if the square brackets are
always required around the <selector>, what purpose do they serve?

> +
> +			<handle>:
> +			<bus-name>/<dev-name>
> +
> +			Configure default devlink eswitch mode for matching
> +			devlink instances during device initialization.
> +
> +			<mode>:
> +			legacy | switchdev | switchdev_inactive
> +
> +			Examples:
> +			devlink_eswitch_mode=[*]:switchdev
> +			devlink_eswitch_mode=[pci/0000:08:00.0]:switchdev
> +			devlink_eswitch_mode=[pci/0000:08:00.0,pci/0000:09:00.1]:legacy
> +
> +			See Documentation/networking/devlink/devlink-defaults.rst
> +			for the full syntax.
> +
>  	dfltcc=		[HW,S390]
>  			Format: { on | off | def_only | inf_only | always }
>  			on:       s390 zlib hardware support for compression on


-- 
~Randy