Re: [PATCH 2/4] ASoC: ti: omap3pandora: remove

[H. Nikolaus Schaller]

> Am 03.06.2026 um 16:00 schrieb Andreas Kemnade <andreas@xxxxxxxxxxxx>:
> 
> On Wed, 03 Jun 2026 14:09:23 +0200
> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> 
>> The omap3pandora driver entirely depends on machine_is_omap3_pandora().
>> Pandora has been converted to device tree:
>> 
>> 7fcf7e061edd3 ("ARM: OMAP2+: Remove legacy booting support for Pandora")

11 years ago :)

>> 
>> Since then machine_is_omap3_pandora() always expands to 0. Remove the
>> long unused driver.
>> 
>> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>> ---
>> sound/soc/ti/Kconfig        |   9 --
>> sound/soc/ti/Makefile       |   2 -
>> sound/soc/ti/omap3pandora.c | 290 --------------------------------------------
>> 3 files changed, 301 deletions(-)
>> 
> On the first glance, this looks ok... but
> I know there was work undergone in converting this to devicetree but it
> appeared not upstream.

Thanks for spotting (before we would have been surprised).

> 
> So
> Grond, hns: What are your plans in this? You are effectively maintaining this
> out-of-mainline. What are your upstreaming plans?
> 
> Do we need this kind of glue anyway? Or can we use some of the
> audio-graph-card stuff instead to wire up things?

Tony also had mentioned something like this in [1].

I have checked the status of the LetuxOS kernel [2]:

There are patches for the device tree (a simple one without audio graphs) and patches
for sound/soc/ti/omap3pandora.c and adding a TI PCM1773 driver.

Main contributors were Grond and Stefan Leichter.

The main work is a patch by Grond: "ASoC: omap3pandora: Rewrite sound card driver as a platform driver".
This heavily modifies sound/soc/ti/omap3pandora.c including removal of machine_is_omap3_pandora()
but keeps sound/soc/ti/Kconfig & Makefile as is.
And he added "ASoC: pcm1773-codec: write a driver for the PCM1773 chip from TI".

So to summarize: the upstream code is the basis for a patch series from 2020-2023. 
I regularily rebased and fixed upstream API changes but it was never posted and there
was no specific plan to do that due to lack of manpower...

Nevertheless, if people are interested, I can consolidate and tidy up this (mainly
the API updates) into a series (approx. 10 to 20 commits) and post as RFC over the next weeks.
Note that this series also affects the TWL4030 REGEN and the twl4030-codec.

And there is a revert for some pandora related omap2/pdata-quirks [3].
BTW: there is also a special Pandora backlight driver which asks for cleanup.

Final observation: we build this with CONFIG_SND_SOC_OMAP3_PANDORA=m and this is also defined
in upstream omap2plus_defconfig [4].

My proposal: keep sound/soc/ti/omap3pandora.c at least while the RFC is discussed.
This will eventually remove machine_is_omap3_pandora().

BR,
Nikolaus

[1] https://marc.info/?l=alsa-devel&m=165632351319716&w=2
[2] https://github.com/goldelico/letux-kernel/commits/letux/sound-soc-v3/
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/configs/omap2plus_defconfig?h=v7.1-rc6#n532
[4] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/mach-omap2/pdata-quirks.c#n271