Re: [PATCH v2 5/8] irqchip/qcom-pdc: Configure PDC to pass through mode

[Thomas Gleixner]

On Tue, May 26 2026 at 16:24, Maulik Shah wrote:
 
> +static inline bool pdc_pin_uses_seconary_mode(int pin_out)
> +{
> +	if (pdc->mode == PDC_SECONDARY_MODE && pin_out >= pdc->num_spis)
> +		return true;

  return pdcc>mode == ... && ...;

Perhaps?

> +static void qcom_pdc_ack(struct irq_data *d)
> +{
> +	if (pdc_pin_uses_seconary_mode(d->hwirq) && !irqd_is_level_type(d))
> +		pdc->clear_gpio(d->hwirq);
> +}
> +
> +static void qcom_pdc_gic_eoi(struct irq_data *d)
> +{
> +	if (pdc_pin_uses_seconary_mode(d->hwirq) && irqd_is_level_type(d))
> +		pdc->clear_gpio(d->hwirq);
> +
> +	irq_chip_eoi_parent(d);
> +}

Not that I care about the performance of your SoC, but those
conditionals can be completely avoided with separate irq chips.