Re: [PATCH v3 2/3] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor
From: Marcelo Schmitt
Date: Wed Jun 03 2026 - 11:02:19 EST
On 06/03, Wadim Mueller wrote:
> On Sun, 31 May 2026 14:45:08 -0300
> Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> wrote:
>
> > We could add a mention to the IRQ pin to make the doc more complete.
> > interrupts:
> > maxItems: 1
>
> I would let interrupts out for now. The driver is polled and in v2 the
> feedback was to not put properties in the binding which we do not use. If
> later a board uses the IRQ pin we can add it. Ok for you?
>
Well, okay for me. I suggested that because of the guidelines for dt-bindings [1].
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/writing-bindings.rst?h=v7.1-rc6#n17
Though, TBH, I'm also frequently tempted to leave interrupt properties out of
bindings. It's not uncommon to have IIO drivers that don't support interrupt
lines and, for those cases, having to describe the interrupts in dt ends up
becoming just an extra task. Even though I don't know/recall the reason why dt
maintainers have such guideline, they probably have a good reason to have that
(right?). If the guidance has changed, then maybe we can update the guidelines
for writing bindings?
With best regards,
Marcelo