RE: [Intel-wired-lan] [PATCH iwl-net] ixgbe: do not configure xps for XDP queues
From: Holda, Patryk
Date: Wed Jun 03 2026 - 10:38:25 EST
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Simon Horman
> Sent: Thursday, May 21, 2026 1:44 PM
> To: Zaremba, Larysa <larysa.zaremba@xxxxxxxxx>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; intel-wired-
> lan@xxxxxxxxxxxxxxxx; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>;
> Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Alexei
7> Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>;
> Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John Fastabend
> <john.fastabend@xxxxxxxxx>; Stanislav Fomichev <sdf@xxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx;
> Lobakin, Aleksander <aleksander.lobakin@xxxxxxxxx>; Loktionov, Aleksandr
> <Aleksandr.Loktionov@xxxxxxxxx>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ixgbe: do not configure xps for
> XDP queues
> Importance: High
>
> On Mon, May 18, 2026 at 01:15:04PM +0200, Larysa Zaremba wrote:
> > netif_set_xps_queue() should not be called for an XDP Tx queue, since
> > such queues are not netdev-exposed. On systems with number of CPUs
> > >=64, on E610 adapter, netdev is configured with maximum number queue
> > pairs being 63 (due to MSI-X assignment), but configuring XDP results in 64
> XDP queues.
> >
> > So, during XDP program load, when netif_set_xps_queue() is called for
> > the last XDP queue, we get a WARNING with a call trace and KASAN
> > report afterwards (if enabled).
> >
> > [ 2012.699800] WARNING: net/core/dev.c:2854 at
> > __netif_set_xps_queue+0x116a/0x1e40, CPU#36: xdpsock/103668
>
> ...
>
> >
> > Skip XPS configuration for XDP Tx queues.
> >
> > Fixes: 33fdc82f0883 ("ixgbe: add support for XDP_TX action")
> > Reviewed-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
>
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
Tested-by: Patryk Holda <patryk.holda@xxxxxxxxx>