Re: [PATCH] staging: axis-fifo: remove driver

[Grewstad]

Adding Michal Simek, as he posted some relevant points in another thread.

On Wed, Jun 3, 2026 at 1:49 PM Michal Simek <michal.simek@xxxxxxx> wrote:
>
> Hi,
>
> On 6/1/26 09:15, Grewstad wrote:

>
> It is clear that driver in current state can't be used with axi ethernet out of
> box because pretty much it is just about user interface for fifo via char device
> fops. But we are talking about the same IP used in specific scenario and this
> driver doesn't implement integration which can be used in ethernet driver.

> I don't think you will find out any in-tree user because driver purpose is
> different. It is about providing a user way via char device to push data to axi
> streaming interface which can be consumed by user logic. It is generic way how
> to push data there without writing specialized kernel driver for custom HW.
> I think this is leaf driver which provide a way to axi fifo streaming interface

> where stream is connected to custom HW which consumes it. I can understand that
> this can be very useful for a lot of people who wants to process data from user
> space via custom logic with using streaming interface.

> And I don't have any issue to agree to move the driver out of staging to common
> location.

Thanks for letting me know. When you say common location, can you give your
opinion on where it can be moved? We cannot find any user-space applications
that use this driver, as you said it is a 'leaf driver'. Because of
this, we do not know
how it is used, who the end users are and hence we dont know where it
can be moved.

Thanks,
Arihan Bhor

On Tue, Jun 2, 2026 at 6:42 PM Dan Carpenter <error27@xxxxxxxxx> wrote:
>
> On Tue, Jun 02, 2026 at 06:31:27PM +0530, Grewstad wrote:
> > On Tue, Jun 2, 2026 at 5:07 PM Dan Carpenter <error27@xxxxxxxxx> wrote:
> > >
> > > On Tue, Jun 02, 2026 at 04:01:53PM +0530, Arihan Bhor wrote:
> > >
> > > I don't think we should delete this driver.  From reading the git
> > > log, Ovidiu Panait was obviously using this code last year.  Let's
> > > also add Jacob Feder, although he hasn't touched the code in 8 years,
> > > he still might know if there are other users.
> >
> > I could not find any user-space applications that depend on this driver.
> >
> > https://lore.kernel.org/lkml/CAD03fjb=_kW9=q9YV4qnQ5GD=HMB5Bx7pf3+AFcgDR2gVc1V6Q@xxxxxxxxxxxxxx/
> > I was looking for any users of this driver on the linux-kernel, linux-staging,
> > and linux-arm-kernel mailing lists as well as Jacob Feder, and received no
> > replies since I posted it 1 day ago. If someone is using it or maintaining a
> > proprietary app, they will complain and we can bring the driver back.
>
> Here are people using it and running into issues in Jan 2025.
> https://adaptivesupport.amd.com/s/question/0D54U00008zRBdISAW/vitis-is-not-creating-a-driver-entry-for-axififomm-43?language=zh_CN
> Someone provides a work around:
> https://adaptivesupport.amd.com/s/question/0D54U00008sLBuMSAW/how-to-use-the-axi-stream-fifo-drivers-xllfifoh-xllfifogc-etc-in-the-project?language=en_US
> Then Ovidiu Panait fixed the bug in Sep by adding the correct
> compatible.
>
> regards,
> dan carpenter