Re: [PATCH v13 4/9] gpu: nova-core: Hopper/Blackwell: add FSP send/receive messaging

[Eliot Courtney]

On Wed Jun 3, 2026 at 4:30 PM JST, Alexandre Courbot wrote:
> From: John Hubbard <jhubbard@xxxxxxxxxx>
>
> FSP exchanges are request/response: the driver sends an MCTP/NVDM
> message and must match the reply against the request before acting on
> it. Add the synchronous send-and-wait path that validates the response
> transport and message headers and confirms the reply corresponds to the
> request that was sent.
>
> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---


> +/// Trait implemented by types representing a message to send to FSP.
> +///
> +/// This provides [`Fsp::send_sync_fsp`] with the information it needs to send
> +/// a given message, following the same pattern as GSP's `CommandToGsp`.
> +pub(crate) trait MessageToFsp: AsBytes {
> +    /// NVDM type identifying this message to FSP.
> +    const NVDM_TYPE: NvdmType;
> +}
> +

nit: this trait can be private (and actually can't meaningfully be used
currently anyway since `send_sync_fsp` is private)

Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>