Re: [RFC] mpam,x86,fs/resctrl: Generic schema description Proof of Concept

[Chen, Yu C]

Hi Reinette,
On 5/30/2026 2:06 AM, Reinette Chatre wrote:

[ ... ]

> /**
>   * struct resctrl_ctrl - A resource control
>   * @entry:	List entry of rdt_resource::controls
>   * @scope:	Scope of the resource that this control allocates
>   * @domains:	RCU list of all control domains
>   * @type:	The control type that determines the properties of the control,
>   *		format string for displaying control values to user space, and
>   *		parser of control values provided by user space.
>   * @name:	Name of the control. Appended to final resource name
>   *		(rdt_resource_final::name) to create final schema entry.
>   *		Specifically, "rdt_resource_final::name"_"resctrl_ctrl::name".
>   *		For example, with resource name "MB" and control name "MAX" the
>   *		schema entry will be "MB_MAX".
>   * @cache:	Cache allocation control properties.
>   * @membw:	Bandwidth control properties.
>   */
> struct resctrl_ctrl {
> 	struct list_head	entry;
> 	enum resctrl_scope	scope;
> 	struct list_head	domains;
> 	enum resctrl_ctrl_type	type;
> 	enum resctrl_ctrl_name	name;
> 	union {
> 		struct resctrl_cache	cache;
> 		struct resctrl_membw	membw;
> 	};
> };

Thanks for re-spinning this patch set.
Looking at commit (fs/resctrl: Introduce additional schema properties),
the newly added properties appear to be implemented for the
MBA resctrl_membw controller.
Would it make sense for these properties to be generic across all resctrl
controllers, CAT included? Should they consequently be relocated into
struct resctrl_ctrl if that approach is appropriate?

thanks,
Chenyu