Re: [PATCH] staging: rtl8723bs: fix coding style in rtw_cmd.c

[Andy Shevchenko]

On Mon, May 25, 2026 at 10:10:01PM +0200, Krzysztof Woś wrote:
> Fix spdx comment style and indentation in rtw_cmd.c to resolve
> errors and warnings reported by checkpatch.pl.

...

> -	pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 - ((SIZE_PTR)(pcmdpriv->rsp_allocated_buf) & 3);
> +	pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 -
> +		((SIZE_PTR)(pcmdpriv->rsp_allocated_buf) & 3);

Is this the only single issue of the type in the entire driver?

Also, now it's harder to read. What this code does is as simple as

	pcmdpriv->rsp_buf = ALIGN(pcmdpriv->rsp_allocated_buf, 4);

(need linux/align.h to be included).

-- 
With Best Regards,
Andy Shevchenko