Re: [PATCH RESEND] n64cart: use strscpy in n64cart_probe

[Thorsten Blum]

Gentle ping?

On Sun, May 17, 2026 at 07:26:17PM +0200, Thorsten Blum wrote:
> strcpy() has been deprecated [1] because it performs no bounds checking
> on the destination buffer, which can lead to buffer overflows. While the
> current code works correctly, replace strcpy() with the safer strscpy()
> to follow secure coding best practices.
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
>  drivers/block/n64cart.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
> index b9fdeff31caf..328da73b6f2c 100644
> --- a/drivers/block/n64cart.c
> +++ b/drivers/block/n64cart.c
> @@ -12,6 +12,7 @@
>  #include <linux/init.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> +#include <linux/string.h>
>  
>  enum {
>  	PI_DRAM_REG = 0,
> @@ -145,7 +146,7 @@ static int __init n64cart_probe(struct platform_device *pdev)
>  	disk->flags = GENHD_FL_NO_PART;
>  	disk->fops = &n64cart_fops;
>  	disk->private_data = &pdev->dev;
> -	strcpy(disk->disk_name, "n64cart");
> +	strscpy(disk->disk_name, "n64cart");
>  
>  	set_capacity(disk, size >> SECTOR_SHIFT);
>  	set_disk_ro(disk, 1);