Re: [PATCH v8 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver
From: Bryan O'Donoghue
Date: Tue Jun 02 2026 - 18:26:04 EST
On 02/06/2026 23:07, Vladimir Zapolskiy wrote:
+ ret = fwnode_property_read_u32(ep, "clock-lanes", &clock_lane);
+ if (ret) {
+ clock_lane = CSI2_DEFAULT_CLK_LN;
+ dev_info(dev, "Using default clock-lane %d\n",
+ CSI2_DEFAULT_CLK_LN);
Why CSI2_DEFAULT_CLK_LN is set to 7, what does it mean and how is it used?
Since "7" is a meaningless number in the context, I believe it's practically
not used at all, and if so, 'clock-lanes' property should be just removed.
Documentation shows clock lane at lane 7.
Truthfully it makes no sense that the clock lane would genuinely be locked to lane 7 but the documentation does seem to suggest it.
Yes in fact I agree. clock-lanes can be reintroduced if someone can show hardware that supports/depends on it.
---
bod