Re: [PATCH] lib/vsprintf: replace min_t/max_t with min/max

From: Andy Shevchenko

Date: Tue Jun 02 2026 - 14:08:24 EST


On Thu, May 21, 2026 at 03:49:12PM +0200, Petr Mladek wrote:
> On Mon 2026-05-18 14:31:47, Thorsten Blum wrote:
> > Use the simpler min()/max() macros since the values are all compatible.

...

> > if (spec.field_width > 0)
> > - len = min_t(int, spec.field_width, 64);
> > + len = min(spec.field_width, 64);
>
> Honestly, I do not see any big advantage in replacing the macros.
> In fact, the min()/max() macros are even more complex because
> they check compatibility of the compared types.
>
> IMHO, this adds non-necessary churn into the git history without
> an obvious advantage.

The advantage I see is to give a good example to others to avoid min_t()
whenever is possible. I am not insisting to include this patch, just
share my 2 cents.

--
With Best Regards,
Andy Shevchenko