Re: [PATCH v4 2/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A

[Pradhan, Sanman]

From: Sanman Pradhan <psanman@xxxxxxxxxxx>

On Mon, Jun 01, 2026 at 19:06:06 +0000, sashiko-bot@xxxxxxxxxx wrote:
> [Severity: High]
> Will this prevent the regulator core from matching the device tree node?
>
> The PMBUS_REGULATOR_ONE("vout") macro sets of_match to "vout". During
> registration, the regulator core searches for a child node named "vout"
> or a parent node with that exact name to associate the of_node.
>
> If the device tree schema expects regulator properties directly on the
> parent node (which is typically named generically, like regulator@xx),
> will the regulator core fail to match the node?
>
> If the match fails, the regulator is registered with of_node = NULL,
> which silently ignores regulator constraints and prevents consumers
> from referencing it as a supply.

The Sashiko AI Review is right that with a generic node like regulator@xx
and no "vout" child, DT init data is NULL.

But that only means no DT constraints were provided; the regulator still
registers successfully and the PMBus regulator ops remain functional.

Saw a similar single-output PMBus regulator pattern [PMBUS_REGULATOR_ONE("vout")]
in drivers/hwmon/pmbus/ir38064.c, just followed that.

Thank you.

Regards,
Sanman Pradhan