Re: [PATCH v3 19/19] mm/mm_init: Fold __init_page_from_nid() into __init_deferred_page()
From: Mike Rapoport
Date: Tue Jun 02 2026 - 11:47:07 EST
On Tue, 02 Jun 2026 18:10:39 +0800, Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 41b83dd18c01..f1bbf3b9a321 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -771,10 +746,27 @@ defer_init(int nid, unsigned long pfn, unsigned long end_pfn)
>
> static void __meminit __init_deferred_page(unsigned long pfn, int nid)
> {
> + pg_data_t *pgdat;
> + int zid;
> +
> if (early_page_initialised(pfn, nid))
> return;
>
> - __init_page_from_nid(pfn, nid);
> + pgdat = NODE_DATA(nid);
Nit: we can initialize pgdat at declaration line, other than that
Reviewed-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
--
Sincerely yours,
Mike.