Re: [PATCH v7 012/120] x86/cpuid: Parse CPUID(0x80000000)

[Ahmed S. Darwish]

On Mon, 01 Jun 2026, Borislav Petkov wrote:
>
> Why are those here?
>
> insert_tag: WARNING: Unknown tag: [References: 67ad24e6d39c ("- pre5:    - Rasmus Andersen: add proper...")  # Historical git], ignoring it...
> insert_tag: WARNING: Unknown tag: [References: 8a50e5135af0 ("x86-32: Use symbolic constants, safer CPUID when enabling EFER.NX")], ignoring it...
>

I thought "References:" is one of the official tags; will remove it.

> >
> > +static void
> > +cpuid_read_0x80000000(const struct cpuid_parse_entry *e, const struct cpuid_read_output *output)
>
> For your whole patchset - remove all those linebreaks pls.
>

ACK.

> >  /*
> >   * CPUID parser table:
> >   */
> > @@ -53,9 +71,11 @@ static const struct cpuid_parse_entry cpuid_parse_entries[] = {
> >  static unsigned int cpuid_range_max_leaf(const struct cpuid_table *t, unsigned int range)
> >  {
> >  	const struct leaf_0x0_0 *l0 = __cpuid_table_subleaf(t, 0x0, 0);
> > +	const struct leaf_0x80000000_0 *el0 = __cpuid_table_subleaf(t, 0x80000000, 0);
>
> The tip-tree preferred ordering of variable declarations at the
> beginning of a function is reverse fir tree order::
>

Just botched this one; will fix.

Thanks,
Ahmed