Re: [PATCH] mac802154: Prevent overwrite return code in mac802154_perform_association()
From: Miquel Raynal
Date: Tue Jun 02 2026 - 06:36:55 EST
Hello,
On 02/06/2026 at 12:41:33 +07, Robertus Diawan Chris <robertusdchris@xxxxxxxxx> wrote:
> When assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL, the
> return value assigned to either "-ERANGE" or "-EPERM" but this return
> value will be overwritten to 0 after exiting the conditional scope.
> So, jump to clear_assoc label to preserve the return value when
> assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL.
>
> This is reported by Coverity Scan as "Unused value".
>
> Fixes: fefd19807fe9 ("mac802154: Handle associating")
> Signed-off-by: Robertus Diawan Chris <robertusdchris@xxxxxxxxx>
This is correct.
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Thanks,
Miquèl