Re: [PATCH v2 3/3] mm/vma: eliminate mmap_action->error_hook, introduce error_filter

[David Hildenbrand (Arm)]

>>>  	/*
>>> -	 * If specified, this hook is invoked when an error occurred when
>>> -	 * attempting the selected action.
>>> -	 *
>>> -	 * The hook can return an error code in order to filter the error, but
>>> -	 * it is not valid to clear the error here.
>>> +	 * If non-zero, filter errors that arise from mmap actions such that we
>>> +	 * return error_filter instead. Only valid error codes may be specified.
>>
>> Is that really a filter or rather an "error conversion" / "error override".
>>
>> "Filter" to my German brain implies that we would ... filter selected error
>> codes, not convert them to something else?
> 
> I thik it's what people tend to call this, it's what I've seen it called anyway!

You mean for this monstrosity or for a mechanism that translates one value to
another one?

> I mean your German brain is being logical :) but by convention going with this
> terminology.

Sorry, but which convention?

-- 
Cheers,

David