Re: [PATCH] x86: smpboot: Always log CPU numbers at info level

[Borislav Petkov]

On Mon, May 04, 2026 at 04:16:39PM +0000, David Sauerwein wrote:

> Subject: Re: [PATCH] x86: smpboot: Always log CPU numbers at info level

x86/smpboot: ...

The tip tree preferred format for patch subject prefixes is
'subsys/component:', e.g. 'x86/apic:', 'x86/mm/fault:', 'sched/fair:',
'genirq/core:'. Please do not use file names or complete file paths as
prefix. 'git log path/to/file' should give you a reasonable hint in most
cases.

The condensed patch description in the subject line should start with a
uppercase letter and should be written in imperative tone.

> announce_cpu uses pr_cont to log CPU numbers of a NUMA node on the same

Please end function names with parentheses.

When a function is mentioned in the changelog, either the text body or the
subject line, please use the format 'function_name()'.

> log line across multiple calls of the function at info level. However,
> if any other message is printed in between these calls, pr_cont is
> unable to continue the previous message and logs a new line at
> KERN_DEFAULT level. On systems where MESSAGE_LOGLEVEL_DEFAULT is left at
> its default value, this causes these lines to show up at warn level.
> 
> [INFO][    0.051137] x86: Booting SMP configuration:
> [INFO][    0.051139] .... node  #0, CPUs:        #1  #2  #3  #4  #5  #6  #7  #8  #9 #10 #11 #12 #13 #14 #15 #16 #17 #18 #19 #20 #21 #22 #23
> [INFO][    0.056620] .... node  #1, CPUs:   #24
> [INFO][    0.006767] smpboot: CPU 24 Converting physical 0 to logical die 1
> [WARN][    0.056761]  #25 #26 #27 #28 #29 #30 #31 #32 #33 #34 #35 #36 #37 #38 #39 #40 #41 #42 #43 #44 #45 #46 #47
> [INFO][    0.060721] .... node  #0, CPUs:   #48
> [WARN][    0.060731] MDS CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/mds.html for more details.
> [WARN][    0.060731] TAA CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.html for more details.
> [WARN][    0.060731] MMIO Stale Data CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/processor_mmio_stale_data.html for more details.
> [WARN][    0.060731]  #49 #50 #51 #52 #53 #54 #55 #56 #57 #58 #59 #60 #61 #62 #63 #64 #65 #66 #67 #68 #69 #70 #71
> [INFO][    0.068678] .... node  #1, CPUs:   #72 #73 #74 #75 #76 #77 #78 #79 #80 #81 #82 #83 #84 #85 #86 #87 #88 #89 #90 #91 #92 #93 #94 #95
> 
> (Example logs collected on a v5.10 based kernel)

But you're sending a patch against the upstream kernel...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette