Re: [PATCH v4] ext2: Remove deprecated DAX support
From: Jan Kara
Date: Mon Jun 01 2026 - 05:31:59 EST
On Thu 28-05-26 13:56:14, Ashwin Gundarapu wrote:
> This indentation warning is from pre-existing code (originally written in
> 2010) that my patch did not touch. I prefer to keep this patch focused
> solely on removing deprecated DAX support. A separate cleanup patch can
> be submitted later if desired.
Actually no, your patch indeed introduced several indentation problems (by
removing some conditions but not reindenting internal blocks). Also there
were some spurious empty lines added. No need to resend, I've fixed that up
on commit. Thanks for the patch.
Honza
> Regards,
> Ashwin Gundarapu
>
> From: kernel test robot <lkp@xxxxxxxxx>
> To: "Ashwin Gundarapu"<linuxuser509@xxxxxxxxxxx>, "jack"<jack@xxxxxxxx>
> Cc: <oe-kbuild-all@xxxxxxxxxxxxxxx>, "linux-ext4"<linux-ext4@xxxxxxxxxxxxxxx>, "linux-kernel"<linux-kernel@xxxxxxxxxxxxxxx>
> Date: Thu, 28 May 2026 09:46:32 +0530
> Subject: Re: [PATCH v4] ext2: Remove deprecated DAX support
>
> > Hi Ashwin,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on jack-fs/for_next]
> > [also build test WARNING on linus/master v7.1-rc5 next-20260527]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Ashwin-Gundarapu/ext2-Remove-deprecated-DAX-support/20260524-233631
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_next
> > patch link: https://lore.kernel.org/r/19e5aa07c9b.3a2e576d130187.5289857983023045470%40zohomail.in
> > patch subject: [PATCH v4] ext2: Remove deprecated DAX support
> > config: arm-randconfig-r071-20260528 (https://download.01.org/0day-ci/archive/20260528/202605281203.e91xvDyr-lkp@xxxxxxxxx/config)
> > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> > smatch: v0.5.0-9185-gbcc58b9c
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202605281203.e91xvDyr-lkp@xxxxxxxxx/
> >
> > smatch warnings:
> > fs/ext2/inode.c:1251 ext2_setsize() warn: inconsistent indenting
> >
> > vim +1251 fs/ext2/inode.c
> >
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1236
> > 2c27c65ed0696f0 Christoph Hellwig 2010-06-04 1237 static int ext2_setsize(struct inode *inode, loff_t newsize)
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1238 {
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1239 int error;
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1240
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1241 if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1242 S_ISLNK(inode->i_mode)))
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1243 return -EINVAL;
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1244 if (ext2_inode_is_fast_symlink(inode))
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1245 return -EINVAL;
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1246 if (IS_APPEND(inode) || IS_IMMUTABLE(inode))
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1247 return -EPERM;
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1248
> > 562c72aa57c36b1 Christoph Hellwig 2011-06-24 1249 inode_dio_wait(inode);
> > 562c72aa57c36b1 Christoph Hellwig 2011-06-24 1250
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 @1251 error = block_truncate_page(inode->i_mapping,
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1252 newsize, ext2_get_block);
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1253 if (error)
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1254 return error;
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1255
> > 70f3bad8c3154ba Jan Kara 2021-04-12 1256 filemap_invalidate_lock(inode->i_mapping);
> > 2c27c65ed0696f0 Christoph Hellwig 2010-06-04 1257 truncate_setsize(inode, newsize);
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1258 __ext2_truncate_blocks(inode, newsize);
> > 70f3bad8c3154ba Jan Kara 2021-04-12 1259 filemap_invalidate_unlock(inode->i_mapping);
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1260
> > 5cdc59fce617a2e Jeff Layton 2023-10-04 1261 inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));
> > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1262 if (inode_needs_sync(inode)) {
> > b0439bbc29f0201 Jan Kara 2026-03-26 1263 mmb_sync(&EXT2_I(inode)->i_metadata_bhs);
> > c37650161a53c01 Christoph Hellwig 2010-10-06 1264 sync_inode_metadata(inode, 1);
> > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1265 } else {
> > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1266 mark_inode_dirty(inode);
> > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1267 }
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1268
> > 737f2e93b9724a3 Nicholas Piggin 2010-05-27 1269 return 0;
> > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1270 }
> > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1271
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> >
> >
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR