Re: [PATCH v3 1/2] mm/slub: introduce helpers for node partial slab state

[Harry Yoo]

On 6/1/26 2:26 PM, Hao Li wrote:
> On Mon, Jun 01, 2026 at 12:38:48PM +0900, Harry Yoo wrote:
>>
>>
>> On 5/29/26 12:50 PM, Hao Li wrote:
>>> Wrap partial slab count inc/dec and flag set/clear into
>>> helper functions to reduce code duplication.
>>>
>>> Note that __add_partial() is called locklessly in
>>> early_kmem_cache_node_alloc(), but since there is no such use case for
>>> removal, __remove_partial() does not exist.
>>
>> nit: __remove_partial() -> clear_partial_node_state()
> 
> Ah, in this sentence, I just wanted to clarify that __remove_partial doesn't
> exist. it's not a typo :)
> 
>> oh wait, it does exist. Let's drop this paragraph?
> 
> This paragraph is just a quick side note to explain why __remove_partial()
> doesn't exist. I noticed that __add_partial lacks a symmetric counterpart,
> which felt a bit abrupt/inconsistent, so I wanted to share some context on why
> that is.

Ah, I see. I was confused because it didn't touch those functions :)
Thanks!

-- 
Cheers,
Harry / Hyeonggon

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature